Added basic customisation for menubar colors #343
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @V1RE! The only problem is if we merge this, we need to support these options even in an eventually, more configurable world. Perhaps thats fine though. |
|
Do you want to go through and wire up other color options too (text, background, highlight)? |
|
Sure, what env vars should I use? |
|
MCFLY_PROMPT_COLOR, MCFLY_HIGHLIGHT_COLOR, MCFLY_SELECTION_COLOR might be all of them? |
|
@cantino What to do with the lightmode setting? this would kind of make that obsolete, right? |
|
Can we integrate this with the new configuration system #407? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#156 looks promising, but hasn't seen much action in the last 2 years. So I
made a quick and simple way to customize the foreground and background colors of the menubar using env vars.
Haven't used rust too much, so lmk if I can improve on anything